solid start alpha running with deno#2153
Open
ashtonjurgens wants to merge 3 commits into
Open
Conversation
The manifest plugin's resolveId hook did not intercept virtual module URLs
starting with /@manifest/. When the dev SSR manifest performed a dynamic
import like:
import('/@manifest/ssr/1745693440524/assets?id=./src/entry-client.tsx')
Vite called resolveId, which returned undefined for these paths. Vite then
fell through to its default filesystem resolver, stripped the query string,
and attempted to load a non-existent file at:
/@manifest/ssr/1745693440524/assets
The load hook was correctly implemented to handle /@manifest IDs (it parsed
the query string, walked the module graph for CSS dependencies, and returned
inline style tags), but it was never reached because resolveId failed first.
Fix: add an early return in resolveId for any ID starting with /@manifest/,
allowing the virtual URL to pass through to the load hook unchanged.
…hang The load hook for the "solid-start:server-fn-manifest" virtual module used a Debouncer that delayed resolution by 1 second (setTimeout). During production builds (Rollup), this timer never fires before Rollup exits, causing: Unexpected early exit. This happens when Promises returned by plugins cannot resolve. Unfinished hook action(s) on exit: (solid-start:server-functions/preload) load "solid-start:server-fn-manifest" The Debouncer was designed for dev-mode HMR batching — deferring regeneration of the manifest when multiple files change in quick succession. However, the compiler plugin already handles invalidation via invalidateModules(), which re-triggers the load hook when server function files change. The Debouncer was therefore redundant even in dev mode. Fix: return the generated import statements synchronously from the load hook. The manifest set is already populated by the time load runs (the compiler plugin's transform hook runs first during both dev and build), so there is no need to wait.
|
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to get solid start alpha running with deno, I encountered a few problems. This is an informational PR of what I had to change to get things running. I can't guarantee nothing has been broken, (especially with 3efff0c) which is why I'm calling it an informational PR.
There are 3 commits (all very small), and each commit has a thorough message to explain the change.