feat(web): graceful error and loading states for billing/offers surfaces

[brendan-kellam]

Fixes SOU-1271

Summary

When the offers/pricing fetch from the deployments server fails, several billing surfaces previously rendered nothing (return null) or silently dismissed themselves, leaving users with a blank area or a vanished dialog. This PR replaces those with recoverable, role-aware error states and tidies the loading UX.

Changes

• Onboarding trial step (trialStep.tsx): on error, reframe the copy to "You're all set" and add a View pricing link instead of a bare Continue button.
• Upsell dialog & panel (upsellDialog.tsx): introduce a shared UpsellLoadError fallback used by both UpsellDialog and UpsellPanel:
  • Something went wrong heading + generic "We couldn't reach Sourcebot's deployments server" copy (no longer presumes the user came for pricing).
  • Try again (retry via react-query refetch) and a Status page link (status.sourcebot.dev), which is resilient to the very failure that triggered the state.
  • Role-aware: owners get an actionable outbound-access hint naming deployments.sourcebot.dev plus a Learn more link to the service-ping docs; members are routed to contact their org admin.
  • The dialog now keeps itself open with this error state (built-in close button remains the dismiss affordance) rather than toasting and auto-closing.
• Loading state (upsellDialog.tsx + the five entitlement-message wrappers): add a loadingVariant prop to UpsellPanel. Full-area, centered feature gates (chat, MCP, analytics, account/workspace Ask connectors) now render a centered spinner; the in-flow license-settings card keeps its layout-matching skeleton.

Test plan

• Block outbound access to deployments.sourcebot.dev (or otherwise force the offers fetch to fail) and verify the error state renders on: the onboarding trial step, the upsell dialog, and each feature-gate page.
• Confirm owner vs member see the role-appropriate copy.
• Confirm Try again refetches and Status page / Learn more open the right URLs.
• Confirm feature gates show a spinner while loading and the license card shows a skeleton.

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4696eee0-3607-4b26-a839-4360a0b7c7c7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch brendan/upsell-error-states-SOU-1271

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

@brendan-kellam your pull request is missing a changelog!