Skip to content

fix(server): switch to flag for service account email#1429

Open
j1n-o9r wants to merge 8 commits into
mainfrom
fix/STACKITCLI-346-align-service-account-attach-detach
Open

fix(server): switch to flag for service account email#1429
j1n-o9r wants to merge 8 commits into
mainfrom
fix/STACKITCLI-346-align-service-account-attach-detach

Conversation

@j1n-o9r
Copy link
Copy Markdown
Contributor

@j1n-o9r j1n-o9r commented Jun 3, 2026

Description

Align server service-account attach/detach with other subcommands (e.g. server network-interface attach/detach).

relates to STACKITCLI-346

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@j1n-o9r j1n-o9r changed the title fix(server): switched to flag for service account email fix(server): switch to flag for service account email Jun 3, 2026
@j1n-o9r j1n-o9r marked this pull request as ready for review June 3, 2026 15:32
@j1n-o9r j1n-o9r requested a review from a team as a code owner June 3, 2026 15:32
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/server/service-account/attach 48.98% (+3.98%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/server/service-account/detach 48.98% (+3.98%) 👍
github.com/stackitcloud/stackit-cli/internal/pkg/flags 61.30% (+1.22%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/server/service-account/attach/attach.go 48.98% (+3.98%) 49 (+9) 24 (+6) 25 (+3) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/server/service-account/detach/detach.go 48.98% (+3.98%) 49 (+9) 24 (+6) 25 (+3) 👍
github.com/stackitcloud/stackit-cli/internal/pkg/flags/email.go 100.00% (+100.00%) 8 (+8) 8 (+8) 0 🌟

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/pkg/flags/email_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant