refac(ske): Use new WaitHelper for waiters#7725
Open
Fyusel wants to merge 1 commit into
Open
Conversation
Fyusel
force-pushed
the
refactor-ske-wait-handler
branch
2 times, most recently
from
ee98c1c to
772fb60
Compare
STACKITSDK-393 Signed-off-by: Alexander Dahmen <alexander.dahmen@inovex.de>
Fyusel
force-pushed
the
refactor-ske-wait-handler
branch
from
772fb60 to
27de359
Compare
rubenhoenle
reviewed
Jun 3, 2026
| } | ||
|
|
||
| // createOrUpdateClusterWaitHandler will wait for cluster creation or update | ||
| func createOrUpdateClusterWaitHandler(ctx context.Context, a ske.DefaultAPI, projectId, region, name string) *wait.AsyncActionHandler[ske.Cluster] { |
Member
There was a problem hiding this comment.
That's a breaking change, you can't do this.
You must keep CreateOrUpdateClusterWaitHandler with public visibility, you can just deprecate it and mark it for removal ("removal" from user perspective, actually we will be changing it to private visibility) in 6 months. Deprecation should contain instructions to migrate to CreateClusterWaitHandler and UpdateClusterWaitHandler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STACKITSDK-393
Description
Checklist
make fmtexamples/directory)make test(will be checked by CI)make lint(will be checked by CI)