Skip to content

chore: remove unused types reference#12452

Merged
kgryte merged 1 commit into
developfrom
philipp/fix-assert-is-empty-collection-unused-ref
Jun 3, 2026
Merged

chore: remove unused types reference#12452
kgryte merged 1 commit into
developfrom
philipp/fix-assert-is-empty-collection-unused-ref

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • removes the unused /// <reference types="@stdlib/types"/> triple-slash directive from the @stdlib/assert/is-empty-collection TypeScript declaration. The declaration only references the built-in any and boolean types, so the directive is unnecessary; the sibling is-empty-array-like-object, which declares an analogous predicate, omits it.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request?

Identified via a TypeScript-declaration audit of the @stdlib/assert namespace.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored primarily by Claude Code (Anthropic's CLI), which audited the @stdlib/assert TypeScript declarations and proposed and applied the fix. I reviewed the changes.


@stdlib-js/reviewers

…ction`

The `/// <reference types="@stdlib/types"/>` directive is unused: the
declaration only references the built-in `any` and `boolean` types. Drop
it to match the sibling `is-empty-array-like-object`, which declares an
analogous predicate without the directive.

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@Planeshifter Planeshifter requested a review from a team June 2, 2026 16:42
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jun 2, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
assert/is-empty-collection $\color{green}102/102$
$\color{green}+100.00\%$
$\color{green}5/5$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}102/102$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter changed the title docs: remove unused types reference in @stdlib/assert/is-empty-collection chore: remove unused types reference in @stdlib/assert/is-empty-collection Jun 2, 2026
@Planeshifter Planeshifter requested a review from kgryte June 2, 2026 16:47
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jun 3, 2026
@kgryte kgryte changed the title chore: remove unused types reference in @stdlib/assert/is-empty-collection chore: remove unused types reference Jun 3, 2026
@kgryte kgryte merged commit 3dc641d into develop Jun 3, 2026
40 checks passed
@kgryte kgryte deleted the philipp/fix-assert-is-empty-collection-unused-ref branch June 3, 2026 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants