fix: address typo in parameter name#12457
Merged
Merged
Conversation
The `Senary` callback type alias declared its leading context parameter
as `thos: V` instead of the reserved `this: V`. As written, TypeScript
treats `thos` as an ordinary first positional parameter, shifting
`value`, `idx`, `xi`, `yi`, `x`, and `y` each by one position and
dropping the intended `this`-context typing entirely. The accompanying
TSDoc documents no `thos` parameter, so the signature no longer matched
the documentation.
Rename the parameter to `this`, matching the sibling `Quinary` type in
the same file and the rest of the `-by` accessor family (e.g.
`acos-by`, `acosh-by`, `acoth-by`, `acovercos-by`, `acoversin-by`).
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Jun 3, 2026
kgryte
changed the title
this context parameter in math/strided/special/acot-by
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
Senarycallback type alias in the@stdlib/math/strided/special/acot-byTypeScript declarations, which declared its leading context parameter asthos: Vinstead of the reservedthis: V. As written, TypeScript treatsthosas an ordinary first positional parameter, shiftingvalue,idx,xi,yi,x, andyeach by one position and dropping the intendedthis-context typing entirely. The accompanying TSDoc documents nothosparameter, so the signature no longer matched the documentation.this, matching the siblingQuinarytype in the same file and the rest of the-byaccessor family (e.g.acos-by,acosh-by,acoth-by,acovercos-by,acoversin-by).Related Issues
No.
Questions
No.
Other
Found via a TypeScript-declaration audit of the
@stdlib/mathnamespace.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This issue was identified by an automated TypeScript-declaration audit run with Claude Code, and the fix was prepared by Claude Code under my review.
@stdlib-js/reviewers