feat: allow resolving keys in task context#968
Merged
bhearsum merged 1 commit intoJun 2, 2026
Conversation
ahal
approved these changes
Jun 2, 2026
Collaborator
ahal
left a comment
ahal
left a comment
There was a problem hiding this comment.
Thanks, lgtm modulo some nits
Collaborator
|
Oh and you'll want to rebase on main to get the new pre-commit-v1 task to unblock landing |
This extends task-context to allow for calling `resolve_keyed_by` is a generic way. Combined with `task-context's` existing support for pulling context from parameters it removes the need for transforms for many usages of `resolve_keyed_by` (I counted at least a dozen or so in Gecko alone, and there's probably many more.) Mostly for simplicitly I chose to re-use `substitution-fields` as a source for what `resolve_keyed_by` should be called on. I could be convinced to maintain a separate list for that (although it might introduce repetition in certain cases). I'm honestly not sure which is preferable.
bhearsum
force-pushed
the
feat-allow-resolving-keys-in-t
branch
from
48a1735 to
6be4256
Compare
bhearsum
added a commit
to bhearsum/taskgraph
that referenced
this pull request
Jun 3, 2026
This is somewhat of a continuation to taskcluster#968 in that it would allow for more `resolve_keyed_by` calls to be replaced by `task-context`. As a concrete example, we use [`by-release-level` in many places in gecko](https://searchfox.org/firefox-main/search?q=by-release-level&path=&case=false®exp=false). Its value is [derived from parameters and some constants](https://searchfox.org/firefox-main/source/taskcluster/gecko_taskgraph/util/attributes.py#157). With this patch, we could register it as custom context and replace a whole bunch of `resolve_keyed_by` calls in transforms, eg: In some python code that's called at taskgraph registration: ``` @custom_context("release-level") def release_level_context(config, task): """Provide ``release-level`` ("production" or "staging"), derived from parameters, so ``by-release-level`` fields can be resolved declaratively.""" return {"release-level": release_level(config.params)} ``` And in various kinds we'd end up with things like: ``` transforms: - taskgraph.transforms.task_context task-defaults: task-context: from-custom: - release-level substitution-fields: - scopes scopes: by-release-level: production: - project:releng:ship-it:server:production - project:releng:ship-it:action:create-new-release staging: - project:releng:ship-it:server:staging - project:releng:ship-it:action:create-new-release ```
bhearsum
added a commit
to bhearsum/taskgraph
that referenced
this pull request
Jun 3, 2026
This is somewhat of a continuation to taskcluster#968 in that it would allow for more `resolve_keyed_by` calls to be replaced by `task-context`. As a concrete example, we use [`by-release-level` in many places in gecko](https://searchfox.org/firefox-main/search?q=by-release-level&path=&case=false®exp=false). Its value is [derived from parameters and some constants](https://searchfox.org/firefox-main/source/taskcluster/gecko_taskgraph/util/attributes.py#157). With this patch, we could register it as custom context and replace a whole bunch of `resolve_keyed_by` calls in transforms, eg: In some python code that's called at taskgraph registration: ``` @custom_context("release-level") def release_level_context(config, task): """Provide ``release-level`` ("production" or "staging"), derived from parameters, so ``by-release-level`` fields can be resolved declaratively.""" return {"release-level": release_level(config.params)} ``` And in various kinds we'd end up with things like: ``` transforms: - taskgraph.transforms.task_context task-defaults: task-context: from-custom: - release-level substitution-fields: - scopes scopes: by-release-level: production: - project:releng:ship-it:server:production - project:releng:ship-it:action:create-new-release staging: - project:releng:ship-it:server:staging - project:releng:ship-it:action:create-new-release ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends task-context to allow for calling
resolve_keyed_byis a generic way. Combined withtask-context'sexisting support for pulling context from parameters it removes the need for transforms for many usages ofresolve_keyed_by(I counted at least a dozen or so in Gecko alone, and there's probably many more.)Mostly for simplicitly I chose to re-use
substitution-fieldsas a source for whatresolve_keyed_byshould be called on. I could be convinced to maintain a separate list for that (although it might introduce repetition in certain cases). I'm honestly not sure which is preferable.