Skip to content

Tools: Topology2: Add 24 kHz rate to topologies with SRC#10597

Open
singalsu wants to merge 3 commits into
thesofproject:mainfrom
singalsu:tplg_add_24k_rate_to_src_pcms
Open

Tools: Topology2: Add 24 kHz rate to topologies with SRC#10597
singalsu wants to merge 3 commits into
thesofproject:mainfrom
singalsu:tplg_add_24k_rate_to_src_pcms

Conversation

@singalsu
Copy link
Copy Markdown
Collaborator

@singalsu singalsu commented Mar 4, 2026

This patch adds the missing 24 kHz rate that is used with MPEG-2 standard based and other codecs. The support started with Linux kernel 6.12.

Note: Build of these topologies needs alsa-lib version TBD.

@singalsu
Copy link
Copy Markdown
Collaborator Author

singalsu commented Mar 4, 2026

Topologies build in SOF CI fails with:

ALSA lib pcm.c:366:(split_rate) unsupported stream rate 24000

Need to have alsa-lib with patch alsa-project/alsa-lib#497

@singalsu
Copy link
Copy Markdown
Collaborator Author

singalsu commented Mar 4, 2026

This PR also depends on #10598 . We can't update alsa-lib with 24 kHz rate support without fixing the topology build issue.

@lgirdwood
Copy link
Copy Markdown
Member

lgirdwood commented Mar 30, 2026

This PR also depends on #10598 . We can't update alsa-lib with 24 kHz rate support without fixing the topology build issue.

Merged. Non draft ?

@singalsu
Copy link
Copy Markdown
Collaborator Author

singalsu commented Apr 9, 2026

This PR also depends on #10598 . We can't update alsa-lib with 24 kHz rate support without fixing the topology build issue.

Merged. Non draft ?

I need to wait for Perex to merge the alsa-lib patch.

@singalsu singalsu mentioned this pull request Apr 9, 2026
Closed
@lgirdwood
Copy link
Copy Markdown
Member

lgirdwood commented Apr 13, 2026

This PR also depends on #10598 . We can't update alsa-lib with 24 kHz rate support without fixing the topology build issue.

Merged. Non draft ?

I need to wait for Perex to merge the alsa-lib patch.

Fyi @singalsu now merged.

@singalsu
Copy link
Copy Markdown
Collaborator Author

singalsu commented Apr 17, 2026

This PR also depends on #10598 . We can't update alsa-lib with 24 kHz rate support without fixing the topology build issue.

Merged. Non draft ?

I need to wait for Perex to merge the alsa-lib patch.

Fyi @singalsu now merged.

He has before closed the PR when merged (alsa-project/alsa-lib#497) but it's still open and I can't see "24 kHz" in latest commit titles.

@singalsu
Copy link
Copy Markdown
Collaborator Author

singalsu commented Apr 22, 2026

He has before closed the PR when merged (alsa-project/alsa-lib#497) but it's still open and I can't see "24 kHz" in latest commit titles.

I pinged today Perex on the alsa-lib PR, hope he responds.

@singalsu singalsu marked this pull request as ready for review May 29, 2026 15:37
@singalsu singalsu requested a review from ranj063 as a code owner May 29, 2026 15:37
Copilot AI review requested due to automatic review settings May 29, 2026 15:37
@singalsu singalsu requested a review from jsarha as a code owner May 29, 2026 15:37
Copilot AI reviewed May 29, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@singalsu singalsu force-pushed the tplg_add_24k_rate_to_src_pcms branch from 7dd260d to bc9a8fc Compare June 2, 2026 14:06
@singalsu
scripts: build-alsa-tools.sh: Update alsa-lib and alsa-utils
c4785ba 
This change updates to Release v1.2.16, needed for extended
sample rates add to SOF topologies.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
@singalsu singalsu force-pushed the tplg_add_24k_rate_to_src_pcms branch from bc9a8fc to 44c5302 Compare June 2, 2026 14:14
@singalsu singalsu requested a review from Copilot June 2, 2026 14:15
Copilot AI reviewed Jun 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

@singalsu singalsu force-pushed the tplg_add_24k_rate_to_src_pcms branch from 44c5302 to 50f0f06 Compare June 2, 2026 14:36
singalsu added 2 commits June 2, 2026 18:26
@singalsu
github: workflows: testbench: Update alsa-lib and alsa-lib
140b001 
This patch updates the commits to Release v1.2.16. It is needed
to build topologies with extended sample rates.

The autoconf install is needed due to dependency from alsa-lib.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
@singalsu
Tools: Topology2: Add 24 kHz rate to topologies with SRC
02bdca6 
This patch adds the missing 24 kHz rate that is used with
MPEG-2 standard based and other codecs. The support started
with Linux kernel 6.12.

Note: Build of these topologies needs alsa-lib version TBD.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
@singalsu singalsu force-pushed the tplg_add_24k_rate_to_src_pcms branch from 50f0f06 to 02bdca6 Compare June 2, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ranj063 ranj063 Awaiting requested review from ranj063 ranj063 is a code owner

@jsarha jsarha Awaiting requested review from jsarha jsarha is a code owner

@lgirdwood lgirdwood Awaiting requested review from lgirdwood lgirdwood is a code owner

@plbossart plbossart Awaiting requested review from plbossart plbossart is a code owner

@mmaka1 mmaka1 Awaiting requested review from mmaka1 mmaka1 is a code owner

@lbetlej lbetlej Awaiting requested review from lbetlej lbetlej is a code owner

@dbaluta dbaluta Awaiting requested review from dbaluta dbaluta is a code owner

@kv2019i kv2019i Awaiting requested review from kv2019i kv2019i is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@singalsu @lgirdwood