-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
chore: adopt Prisma 7 beta (tsgo) #3813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
deepshekhardas
wants to merge
20
commits into
triggerdotdev:main
from
deepshekhardas:feat/prisma-7-upgrade
Closed
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
ed41f0a
fix(cli-v3): allow disabling source-map-support to prevent OOM with S…
023c3fd
fix(cli-v3): ignore engine checks during deployment install to preven…
93aa053
fix(core): delegate to original console in ConsoleInterceptor to pres…
8b684e1
fix(cli-v3): authenticate to Docker Hub to prevent rate limits (#2911)
737ad56
fix(cli-v3): ensure worker cleanup on SIGINT/SIGTERM (#2909)
c97cbcc
verify: add reproduction scripts and PR details for all major fixes
aa90db9
verify: add reproduction scripts and PR details for all major fixes
f5ce2bc
docs: add consolidated PR body description
8c986db
chore: remove reproduction scripts and temporary files
82f198f
Merge remote-tracking branch 'remotes/origin/fix/sentry-oom-2920'
9a3e8d0
Merge branch 'fix/issue-2909-orphaned-workers'
e101f8e
chore: remove reproduction scripts after verification
d01d438
fix: resolve typecheck errors after merge
aafb736
fix(webapp): auto-recover replication services after stream errors
ericallam 7fa3a16
fix(webapp): reschedule reconnect when subscribe() throws
ericallam 4e6461a
fix(webapp): reschedule reconnect when subscribe() returns stopped
ericallam 4b5db51
fix(webapp): drop bogus isStopped check, route leader-lock failure th…
ericallam 5365936
fix(webapp): scope leaderElection-lost recovery to reconnect strategy
ericallam d35bf04
Merge pull request #10 from deepshekhardas/pr/3613-replication-fix
deepshekhardas 5f4c41a
feat: migrate Prisma from 6.14.0 to 7.7.0 with driver adapters (PR #3…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@trigger.dev/core": patch | ||
| --- | ||
|
|
||
| Fix: ConsoleInterceptor now delegates to original console methods to preserve log chain when other interceptors (like Sentry) are present. (#2900) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@trigger.dev/cli-v3": patch | ||
| --- | ||
|
|
||
| Fix: Native build server failed with Docker Hub rate limits. Added support for checking checking `DOCKER_USERNAME` and `DOCKER_PASSWORD` in environment variables and logging into Docker Hub before building. (#2911) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@trigger.dev/cli-v3": patch | ||
| --- | ||
|
|
||
| Fix: Ignore engine checks during deployment install phase to prevent failure on build server when Node version mismatch exists. (#2913) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@trigger.dev/cli-v3": patch | ||
| --- | ||
|
|
||
| Fix: `trigger.dev dev` command left orphaned worker processes when exited via Ctrl+C (SIGINT). Added signal handlers to ensure proper cleanup of child processes and lockfiles. (#2909) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@trigger.dev/cli-v3": patch | ||
| --- | ||
|
|
||
| Fix Sentry OOM: Allow disabling `source-map-support` via `TRIGGER_SOURCE_MAPS=false`. Also supports `node` for native source maps. (#2920) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| area: webapp | ||
| type: fix | ||
| --- | ||
|
|
||
| Runs and sessions replication services now auto-recover from stream errors (e.g. after a Postgres failover) instead of silently leaving replication stopped. Behaviour is configurable per service — reconnect (default), exit so a process supervisor can restart the host, or log. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚩 DATABASE_POOL_TIMEOUT env var is now unused after PrismaPg migration
The old Prisma connection string accepted
pool_timeout(mapped fromenv.DATABASE_POOL_TIMEOUT, default 60s) andconnection_timeout(mapped fromenv.DATABASE_CONNECTION_TIMEOUT, default 20s). The new PrismaPg adapter atapps/webapp/app/db.server.ts:143-144usesenv.DATABASE_CONNECTION_TIMEOUT * 1000for bothidleTimeoutMillisandconnectionTimeoutMillis. TheDATABASE_POOL_TIMEOUTenv var defined atapps/webapp/app/env.server.ts:103is now dead — any existing deployments that tunedDATABASE_POOL_TIMEOUTseparately fromDATABASE_CONNECTION_TIMEOUTwill silently lose that customization. Additionally,idleTimeoutMillis(how long idle connections stay in the pool) is semantically different from the old Prismapool_timeout(how long to wait for a free connection). The 20s idle timeout may cause more connection churn than the previous 60s pool_timeout in high-concurrency scenarios.Was this helpful? React with 👍 or 👎 to provide feedback.